Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope coaching_relationships query by user_id #93

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

calebbourg
Copy link
Collaborator

@calebbourg calebbourg commented Dec 17, 2024

Description

Updates coaching_relationships index endpoint to scope query by the current user.

GitHub Issue: Fixes #92

Changes

  • Update coaching_relationships endpoint
  • Update entity_api::coaching_relationships::find_by_organization_with_user_namesto accept auser_id`

Testing Strategy

describe how you or someone else can test and verify the changes

@calebbourg calebbourg self-assigned this Dec 17, 2024
@calebbourg calebbourg added the bug fix Contains a fix to a known bug label Dec 17, 2024
@calebbourg calebbourg requested a review from jhodapp December 17, 2024 19:48
@jhodapp jhodapp modified the milestone: 1.0-rc1 Dec 17, 2024
Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, I checked as a coach user and a coachee user and got what I expected on the dashboard page.

@calebbourg calebbourg merged commit e120410 into main Dec 17, 2024
4 checks passed
@calebbourg calebbourg deleted the scope_coaching_relationships_by_current_user branch December 17, 2024 20:02
@jhodapp jhodapp added this to the 1.0-rc2 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Contains a fix to a known bug
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: a coachee should only be able to see and select their own coach relationship and coaching sessions
2 participants