make aws keys optional (for use IAM S3 role)

[artempartos]

close #1

• Use with IAM role:

# config/initializers/refile.rb
require "refile/s3"
aws = {
  region: "sa-east-1",
  bucket: "my-bucket",
}

Refile.cache = Refile::S3.new(prefix: "cache", **aws)
Refile.store = Refile::S3.new(prefix: "store", **aws)

• Use without IAM role (no changes):

# config/initializers/refile.rb
require "refile/s3"

aws = {
  access_key_id: "xyz",
  secret_access_key: "abc",
  region: "sa-east-1",
  bucket: "my-bucket",
}
Refile.cache = Refile::S3.new(prefix: "cache", **aws)
Refile.store = Refile::S3.new(prefix: "store", **aws)

[jnicklas]

Can we just strike this? I think copying between two different S3 accounts will not work. Is there some other way to determine which account we're working with?

[artempartos]

Yes, i think we can fetch access_key_id from client configuration. it will work in all auth cases:

• Credentials passed to the AWS.config (this method now we use)
• Environment Variables
• The credentials file's default profile
• Instance profile credentials (this method i need)

more about this - http://docs.aws.amazon.com/AWSSdkDocsRuby/latest//DeveloperGuide/prog-basics-creds.html)
I fix my PR soon

[jnicklas]

Nice! Thank you!

[fredkelly]

I'm trying to use IAM roles but passing just region and bucket is giving me the following error:

DEPRECATION WARNING: called deprecated method `access_key_id' of an Aws::CredentialProvider, use #credentials instead

(I'm sourcing the gem from github to get this PR).

I've seen the discussion in #18 but my configuration appears to be correct:

# config/initializers/refile.rb
require 'refile/s3'

if Rails.env.production?
  aws = {
    region: ENV['AWS_REGION'],
    bucket: ENV['ATTACHMENT_BUCKET']
  }

  Refile.cache = Refile::S3.new(prefix: 'cache', max_size: 10.megabytes, **aws)
  Refile.store = Refile::S3.new(prefix: 'store', **aws)
end

# config/initializers/aws.rb
if Rails.env.production?
  Aws.config.update({
    region: ENV['AWS_REGION'],
    credentials: Aws::InstanceProfileCredentials.new()
  })
end

Edited: copied the wrong error.