Add support for HTTP Proxy #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not enough to define http_proxy on S3 configs because inside of RefileS3#open that setting was not considered, failing to open the URL. So this change extracts proxy from S3's settings and forwards them to Kernel.open, as described here: https://docs.ruby-lang.org/en/2.0.0/OpenURI/OpenRead.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not enough to define
http_proxyon S3 configs because inside ofRefile::S3#openthat setting was not considered, failing to open the URL.So this change extracts proxy from S3's settings and forwards them to
Kernel.open, that forwards them to OpenURI, as documented here:https://docs.ruby-lang.org/en/2.0.0/OpenURI/OpenRead.html