Skip to content

Commit

Permalink
Pip freeze is not as important when everything is frozen in the docke…
Browse files Browse the repository at this point in the history
…r image

(and the real solution is pipenv, anyway: #145.)
  • Loading branch information
mccalluc committed Aug 9, 2018
1 parent 25c454e commit 3f27d83
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 71 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ language: python
python:
- 3.6.0
install:
- pip install -r requirements-freeze.txt
- pip install -r requirements-dev.txt
- pip install -r context/requirements.txt
- npm install cypress --save-dev

# TODO: Is the Travis Node/NPM good enough?
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ Check out the project and install dependencies:
$ python --version
$ git clone https://github.com/refinery-project/heatmap-scatter-dash.git
$ cd heatmap-scatter-dash
$ pip install -r requirements-freeze.txt
$ pip install -r requirements-dev.txt
$ pip install -r context/requirements.txt
```

Then run it locally:
Expand Down
54 changes: 0 additions & 54 deletions requirements-freeze.txt

This file was deleted.

15 changes: 0 additions & 15 deletions test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,6 @@ isort --recursive context --check-only || die "Run 'isort --recursive context'"
end isort


start pip
# Request from githubusercontent.com was failing...
#URL_BASE=https://raw.githubusercontent.com/refinery-platform/heatmap-scatter-dash/master
#DIFF_RAW=$(diff <(cat context/requirements.txt; \
# cat requirements-dev.txt) \
# <(curl --silent $URL_BASE/context/requirements.txt; \
# curl --silent $URL_BASE/requirements-dev.txt))
#DIFF_FREEZE=$(diff requirements-freeze.txt <(curl --silent $URL_BASE/requirements-freeze.txt))
#[ "$DIFF_RAW" ] && [ -z "$DIFF_FREEZE" ] && \
# die "If raw changes, freeze should change: '$DIFF_RAW'"
#[ -z "$DIFF_RAW" ] && [ "$DIFF_FREEZE" ] && \
# die "If freeze changes, raw should change: '$DIFF_FREEZE'"
end pip


start usage
diff <(perl -ne 'print if /^usage:/../^ --api_prefix/' README.md) \
<(cd context; ./app_runner.py -h) || \
Expand Down

0 comments on commit 3f27d83

Please sign in to comment.