Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We really want "padj" or "fdr", not just p-value #201

Open
mccalluc opened this issue Jul 19, 2018 · 3 comments
Open

We really want "padj" or "fdr", not just p-value #201

mccalluc opened this issue Jul 19, 2018 · 3 comments

Comments

@mccalluc
Copy link
Member

No description provided.

@mccalluc
Copy link
Member Author

mccalluc commented Aug 12, 2018

@gmnelson : I'm guessing that more than one of these could be present, and that the preferences are ordered? And for p-value, we're taking the negative log... is that behavior also desired for these other options?

@mccalluc
Copy link
Member Author

geoff notes:

so, I've seen tools produce output with "padj" and "q_value" -- both of these should mean the same thing

have you seen "fdr" in an output, perhaps from Meeta?

I wouldn't think you would see more than one of these fields in a given output
and yes, we'll want -log10 of whatever adjusted p-value is provided in terms of making the volcano plot

I myself have not seen "fdr" but I think she told me it was a possibility. I didn't know about "q_value"... reopening to handle that case.

@mccalluc mccalluc reopened this Aug 15, 2018
@gmnelson
Copy link

@mccalluc Sounds good. Even if "fdr" is used, I still don't think we'd see more than 1 of these terms used in a given output. So I wouldn't worry about establishing priority amongst the terms until we observe an output that would require that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants