Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mccalluc/more re options #217

Merged
merged 9 commits into from
Aug 13, 2018
Merged

Mccalluc/more re options #217

merged 9 commits into from
Aug 13, 2018

Conversation

mccalluc
Copy link
Member

Fix #201: When the details get really finicky, I've been moving them up and out. I don't think we want to make these configurable at run time, but if a change were requested it could be made in the constants, or in the commandline which docker invokes.

@mccalluc mccalluc requested review from scottx611x and jkmarx August 13, 2018 15:22
@@ -157,6 +160,10 @@ def error_page():
)


P_VALUE_RE_LIST = [r'p.*value', r'padj', r'fdr']
LOG_FOLD_RE_LIST = [r'\blog[^a-z]']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per discussion, move up.

@mccalluc mccalluc merged commit 134cf0c into master Aug 13, 2018
@mccalluc mccalluc deleted the mccalluc/more-re-options branch August 13, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants