Add 'samba::additional_config' option #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on the spec failures and will force-push a new commit momentarily. |
This allows the user of the module to specify arbitrary server
configuration options. For example, in hiera:
samba::additional_config:
server_multi_channel_support: yes
aio_read_size: 1
aio_write_size: 1
min_receivefile_size: 16384
This would write the following to /etc/samba/smb.conf:
server multi channel support = yes
aio read size = 1
aio write size = 1
min receivefile size = 16384
|
Thanks so much @rehanone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @rehanone, another one for you to consider. There are a bunch of unsupported server configs, so I wonder if we could add a very flexible system for allowing the user to specify them.
This allows the user of the module to specify arbitrary server configuration options. For example, in hiera:
This would write the following to
smb.conf:Fixes #31.