Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Residential and commercial floor space #1197

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

robinhasse
Copy link
Contributor

Purpose of this PR

If the input data allows, the parameter p36_floorspace now distinguishes reidential, commercial and total buildings. This parameter is not used in the optimisation but passed to remind2 to report sub-sectoral floor space.

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I have performed a self-review of my own code
  • Changes are commented, particularly in hard-to-understand areas
  • I have updated the in-code documentation
  • I have adjusted reporting where it was needed
  • All automated model tests pass (FAIL 0 in the output of make test)

@robinhasse
Copy link
Contributor Author

robinhasse commented Jan 25, 2023

Might be an overkill but I included the if clause to not loose backwards compatibility with old input data due to this minor change. Once other development requires new input data anyways, I will remove the tolerance for old input data here too.

Update: With the current implementation, there is no backwards compatibility (tolerance for old input data) as this does not seem to be a relevant use case.

@robinhasse robinhasse force-pushed the resComFloorReporting branch 4 times, most recently from 67ffc3f to 5d31267 Compare January 27, 2023 08:05
@robinhasse robinhasse force-pushed the resComFloorReporting branch from 5d31267 to c6ff20c Compare August 21, 2023 07:59
@robinhasse robinhasse force-pushed the resComFloorReporting branch from c6ff20c to 104276c Compare August 22, 2023 05:51
@LaviniaBaumstark
Copy link
Member

what is the status of thsi PR? will you continue working on it?

1 similar comment
@LaviniaBaumstark
Copy link
Member

what is the status of thsi PR? will you continue working on it?

@LaviniaBaumstark
Copy link
Member

can this PR be closed @robinhasse ?

@robinhasse
Copy link
Contributor Author

can this PR be closed @robinhasse ?

No, I still want to merge this one day and have it on my list. Just quite low, sorry.

@LaviniaBaumstark
Copy link
Member

is this PR also relevant for our next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants