Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for exogenous CO2 prices from reference gdx #1698

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

support for exogenous CO2 prices from reference gdx #1698

wants to merge 15 commits into from

Conversation

Renato-Rodrigues
Copy link
Member

@Renato-Rodrigues Renato-Rodrigues commented Jun 11, 2024 •
edited
Loading

Purpose of this PR

  • add support for defining exogenous CO2 prices from the reference gdx.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
    /p/projects/ecemf/tmp/test_exogenousPriceFromGDX/output/force_co2_2024-06-11_19.34.05

@Renato-Rodrigues Renato-Rodrigues marked this pull request as ready for review June 11, 2024 18:45
ricardarosemann
ricardarosemann approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@ricardarosemann ricardarosemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for implementing this :-)

@LaviniaBaumstark
Copy link
Member

Why is this PR still open?

@Renato-Rodrigues
Copy link
Member Author

It requires remind reporting changes that were still not implemented as described in the unchecked item in the check list.

@LaviniaBaumstark
Copy link
Member

is this PR needed for the next release? Will it be merged very soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardarosemann ricardarosemann ricardarosemann approved these changes

@fschreyer fschreyer Awaiting requested review from fschreyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Renato-Rodrigues @LaviniaBaumstark @ricardarosemann