Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ECEMF scenarios (they are only used in EDGE-T standalone) #1834

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

johannah-pik
Copy link
Contributor

@johannah-pik johannah-pik commented Sep 19, 2024

Purpose of this PR

This PR

  1. Removes the ECEMF scenarios. So far they are not used in REMIND (only in EDGE-T standalone) and they have no associated REMIND demand scenario that is coordinated with other sectors.
  2. Removes edge-t internal demand scenario SSP2EU_demRedStrong from REMIND demand scenarios

This PR is connected to PR#549 in mrremind

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@johannah-pik johannah-pik changed the title Remove unwanted scenarios Remove ECEMF scenarios (they are only used in EDGE-T standalone) Sep 19, 2024
@johannah-pik
Copy link
Contributor Author

@LaviniaBaumstark brauchen wir jetzt schon neue input daten, damit es keinen domain error gibt wenn wir die szenarien entfernen?

@LaviniaBaumstark
Copy link
Member

ja, genau, das kann erst gemert werden, wenn wir neue input daten haben.

@LaviniaBaumstark
Copy link
Member

with the new input data rev7.14 this can be merged, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants