fix(dev): optimizeDeps entries file paths on Windows #10257
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Normalize Path for Vite Dependency Optimization on Windows
This PR addresses an issue with Vite's dependency optimization on Windows systems where incorrect path formats can lead to constant dependency reloading and performance degradation.
Problem:
On Windows, paths often use backslashes (
\
) as separators, while Vite expects forward slashes (/
). This mismatch can cause Vite to incorrectly identify and optimize dependencies.Example:
C:\data\projects\remix\app\entry.client.tsx
C:/data/projects/remix/app/entry.client.tsx
Solution:
This PR normalizes the paths using
importViteEsmSync().normalizePath()
to ensure they are compatible with Vite's dependency optimization.Specific Changes:
Expected Benefits:
Testing:
Please thoroughly test this change on Windows systems to verify that the issue is resolved and there are no unintended side effects.
Additional Considerations:
Please review and merge this PR if the changes are satisfactory.