Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ensure AbortController installed globally #4391

Merged
merged 1 commit into from
Oct 21, 2022
Merged

chore: ensure AbortController installed globally #4391

merged 1 commit into from
Oct 21, 2022

Conversation

jacob-ebey
Copy link
Member

Make sure AbortController is installed globally for node version less than 15.

Closes: #

  • Docs
  • Tests

Testing Strategy:

Existing deployment tests will validate the change.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2022

⚠️ No Changeset found

Latest commit: 89a6241

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chaance
chaance reviewed Oct 19, 2022
View reviewed changes
packages/remix-node/globals.ts
@@ -35,6 +36,8 @@ declare global {

ReadableStream: typeof ReadableStream;
WritableStream: typeof WritableStream;

AbortController: typeof AbortController;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacob-ebey Looking at the abort-controller repo, it looks like there may be a few issues with its typings that could potentially cause issues when passing signals.

mysticatea/abort-controller#16 (comment)
mysticatea/abort-controller#36

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not an issue at runtime as we are currently running tests using it. As long as the build passes and doesn't have type issues it's not an issue.

@jacob-ebey jacob-ebey marked this pull request as ready for review October 19, 2022 22:04
@jacob-ebey jacob-ebey merged commit f5c47d8 into dev Oct 21, 2022
@jacob-ebey jacob-ebey deleted the polyfil-abort-controller branch October 21, 2022 04:15
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 21, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-9868b20-20221021 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
@jacob-ebey @kentcdodds
chore: ensure AbortController installed globally (#4391)
28dcb62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

@chaance chaance chaance approved these changes

Assignees
No one assigned
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacob-ebey @chaance @mcansh