Custom error handling #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to error-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got into the weeds there a bit, but I refactored existing errors and errors that were described in the doc strings to have custom error classes with descriptions. It is a wide change across the code base, I believe it has been done correctly. It will need to be vetted and tested extensively before being deployed to main. Particularly the module/client.py as that has the most extensive revisions.
This is in preparation to update the cli to automatically display the help menu of the menu you're on when you make an error with a command for the cli inputs. Which i will get to at some point.
There is a logger included in the repo, its currently not being used anywhere since you have your own messaging solution, but i did want to ask how i should go about displaying the help menu. makes more sense to use existing messaging, i think i got ahead of my self. Let me know how you'd like me to proceed. I wont have a ton more time this week, but i should be able to tackle it again by end of the weekend.
Full disclosure, this was done by an AI agent. I have it tuned to do tasks like this very accurately but there is still a good 5% of wiggle room for error, so I would not be surprised if there were a few things that were slightly out of whack.