feat: add governance config fields to global params proposal

renlabs-dev · Jan 8, 2025 · c6b51f4 · c6b51f4
1 parent 429277f
commit c6b51f4
Show file tree

Hide file tree

Showing 5 changed files with 59 additions and 12 deletions.
diff --git a/pallets/governance/src/benchmarks.rs b/pallets/governance/src/benchmarks.rs
@@ -129,6 +129,7 @@ benchmarks! {
             min_staking_fee: 1,
             dividends_participation_weight: Percent::zero(),
             proposal_cost: 0,
+            ..Default::default()
         };
         let data = vec![0];
 

diff --git a/pallets/governance/src/lib.rs b/pallets/governance/src/lib.rs
@@ -99,10 +99,6 @@ pub mod pallet {
         #[pallet::constant]
         type MaxApplicationDataLength: Get<u32>;
 
-        #[pallet::constant]
-        #[pallet::no_default_bounds]
-        type ApplicationExpiration: Get<BlockNumberFor<Self>>;
-
         #[pallet::constant]
         type MaxPenaltyPercentage: Get<Percent>;
 
@@ -492,6 +488,10 @@ pub mod pallet {
         InvalidMinStakingFee,
         /// Invalid params given to Emission proposal
         InvalidEmissionProposalData,
+        /// Invalid proposal reward interval given to global params proposal
+        InvalidProposalRewardInterval,
+        /// Invalid agent application cost given to global params proposal
+        InvalidAgentApplicationCost,
     }
 }
 

diff --git a/pallets/governance/src/proposal.rs b/pallets/governance/src/proposal.rs
@@ -1,13 +1,15 @@
+use crate::config::GovernanceConfiguration;
 use crate::frame::traits::ExistenceRequirement;
+use crate::BlockAmount;
 use crate::BoundedBTreeSet;
 use crate::BoundedVec;
 use crate::DebugNoBound;
+use crate::NotDelegatingVotingPower;
 use crate::TypeInfo;
 use crate::{
     AccountIdOf, BalanceOf, DaoTreasuryAddress, Error, GlobalGovernanceConfig, Proposals,
     UnrewardedProposals,
 };
-use crate::{GovernanceConfiguration, NotDelegatingVotingPower};
 use codec::{Decode, Encode, MaxEncodedLen};
 use polkadot_sdk::frame_election_provider_support::Get;
 use polkadot_sdk::frame_support::traits::Currency;
@@ -98,6 +100,12 @@ impl<T: crate::Config> Proposal<T> {
                     min_staking_fee,
                     dividends_participation_weight,
                     proposal_cost,
+                    proposal_expiration,
+                    agent_application_cost,
+                    agent_application_expiration,
+                    proposal_reward_treasury_allocation,
+                    max_proposal_reward_treasury_allocation,
+                    proposal_reward_interval,
                 } = data;
 
                 pallet_torus0::MinNameLength::<T>::set(min_name_length);
@@ -113,8 +121,15 @@ impl<T: crate::Config> Proposal<T> {
                 });
                 pallet_emission0::MaxAllowedWeights::<T>::set(max_allowed_weights);
                 pallet_emission0::MinStakePerWeight::<T>::set(min_stake_per_weight);
-                crate::GlobalGovernanceConfig::<T>::mutate(|config| {
-                    config.proposal_cost = proposal_cost;
+
+                crate::GlobalGovernanceConfig::<T>::set(GovernanceConfiguration::<T> {
+                    proposal_cost,
+                    proposal_expiration,
+                    agent_application_cost,
+                    agent_application_expiration,
+                    proposal_reward_treasury_allocation,
+                    max_proposal_reward_treasury_allocation,
+                    proposal_reward_interval,
                 });
             }
             ProposalData::TransferDaoTreasury { account, amount } => {
@@ -205,6 +220,12 @@ pub struct GlobalParamsData<T: crate::Config> {
     pub min_staking_fee: u8,
     pub dividends_participation_weight: Percent,
     pub proposal_cost: BalanceOf<T>,
+    pub proposal_expiration: BlockAmount,
+    pub agent_application_cost: BalanceOf<T>,
+    pub agent_application_expiration: BlockAmount,
+    pub proposal_reward_treasury_allocation: Percent,
+    pub max_proposal_reward_treasury_allocation: BalanceOf<T>,
+    pub proposal_reward_interval: BlockAmount,
 }
 
 impl<T: crate::Config> Default for GlobalParamsData<T> {
@@ -220,6 +241,13 @@ impl<T: crate::Config> Default for GlobalParamsData<T> {
             dividends_participation_weight:
                 <T as pallet_torus0::Config>::DefaultDividendsParticipationWeight::get(),
             proposal_cost: T::DefaultProposalCost::get(),
+            proposal_expiration: T::DefaultProposalExpiration::get(),
+            agent_application_cost: T::DefaultAgentApplicationCost::get(),
+            agent_application_expiration: T::DefaultAgentApplicationExpiration::get(),
+            proposal_reward_treasury_allocation: T::DefaultProposalRewardTreasuryAllocation::get(),
+            max_proposal_reward_treasury_allocation:
+                T::DefaultMaxProposalRewardTreasuryAllocation::get(),
+            proposal_reward_interval: T::DefaultProposalRewardInterval::get(),
         }
     }
 }
@@ -261,6 +289,21 @@ impl<T: crate::Config> GlobalParamsData<T> {
             crate::Error::<T>::InvalidProposalCost
         );
 
+        ensure!(
+            (5_400..u64::MAX).contains(&self.proposal_expiration),
+            crate::Error::<T>::InvalidProposalExpiration
+        );
+
+        ensure!(
+            self.agent_application_cost <= 100_000_000_000_000_000_000_000,
+            crate::Error::<T>::InvalidAgentApplicationCost
+        );
+
+        ensure!(
+            self.proposal_reward_interval <= 100_000,
+            crate::Error::<T>::InvalidProposalRewardInterval
+        );
+
         Ok(())
     }
 }
@@ -385,10 +428,17 @@ fn add_proposal<T: crate::Config>(
 
     let current_block = <polkadot_sdk::frame_system::Pallet<T>>::block_number();
 
+    let expiration_block = match &data {
+        ProposalData::Emission { .. } => {
+            (current_block + 21_600).max(current_block + config.proposal_expiration)
+        }
+        _ => current_block + config.proposal_expiration,
+    };
+
     let proposal = Proposal::<T> {
         id: proposal_id,
         proposer,
-        expiration_block: current_block + config.proposal_expiration,
+        expiration_block,
         data,
         status: ProposalStatus::Open {
             votes_for: BoundedBTreeSet::new(),

diff --git a/runtime/src/configs.rs b/runtime/src/configs.rs
@@ -372,8 +372,6 @@ impl pallet_governance::Config for Runtime {
 
     type MaxApplicationDataLength = ConstU32<256>;
 
-    type ApplicationExpiration = ConstU64<2000>;
-
     type MaxPenaltyPercentage = MaxPenaltyPercentage;
 
     type DefaultTreasuryEmissionFee = DefaultTreasuryEmissionFee;

diff --git a/test-utils/src/lib.rs b/test-utils/src/lib.rs
@@ -184,8 +184,6 @@ impl pallet_governance::Config for Test {
 
     type MaxApplicationDataLength = ConstU32<256>;
 
-    type ApplicationExpiration = ConstU64<2000>;
-
     type MaxPenaltyPercentage = MaxPenaltyPercentage;
 
     type DefaultTreasuryEmissionFee = DefaultTreasuryEmissionFee;