Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update: Relocate essential NextJS installation instructions for … #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Swertin
Copy link

@Swertin Swertin commented Oct 1, 2024

…easier access

When installing the appkit package for NextJS, the "Extra Configuration" section is essential to running the local server. If the configuration isn't implemented, you're unable to proceed with any of the "Implementation" section.

Therefore, it makes much more sense for it be located before the "Implementation" section.

This change would've saved me a good chunk of time as I didn't bother scrolling to the bottom. I didn't scroll to the bottom because I was still stuck on the installation step.

…easier access

When installing the appkit package for NextJS, the "Extra Configuration" section is essential to running the local server. If the configuration isn't implemented, you're unable to proceed with any of the "Implementation" section. 

Therefore, it makes much more sense for it be located before the "Implementation" section.

This change would've saved me a good chunk of time as I didn't bother scrolling to the bottom. I didn't scroll to the bottom because I was still stuck on the installation step.
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reown-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 5:58pm

@rtomas
Copy link
Collaborator

rtomas commented Oct 12, 2024

@Swertin your suggestion seems ok to me ... but you put it into the Solana Section.

please put if before ## Cloud Configuration and out the tabs

@rtomas rtomas self-requested a review October 12, 2024 12:41
Copy link
Collaborator

@rohit-710 rohit-710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please address the comment left by @rtomas? There is also a minor conflict between your branch and the main branch.

Please make a commit to fix that as well and then we can merge it

@rohit-710 rohit-710 self-requested a review November 4, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants