WIP feat(collector): improve remote host collector speed #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccampbell
reviewed
Nov 4, 2024
pkg/supportbundle/collect.go
Outdated
| results[file] = []byte(data) | ||
| } | ||
|
|
||
| time.Sleep(1 * time.Second) |
pkg/supportbundle/collect.go
Outdated
| } | ||
|
|
||
| // wait for log stream to catch up | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
Sleep isn't great here. Better to wait for the object. This will be brittle
There was a problem hiding this comment.
Thank you! Agree, I am trying to use polling method. However, the previous PR will be refactored. This PR will be on hold.
DexterYan
force-pushed
the
dx/sc-114420/daemonset
branch
from
3c8db66 to
3f7b532
Compare
pkg/supportbundle/collect.go
Outdated
Comment on lines
355
to
364
| for _, pod := range pods.Items { | ||
| eg.Go(func() error { | ||
| // TODO: set timeout waiting | ||
| if err := waitForPodRunning(ctx, clientset, &pod); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| results := map[string][]byte{} | ||
| for _, collectorSpec := range hostCollectors { | ||
| collector, ok := collect.GetHostCollector(collectorSpec, bundlePath) |
There was a problem hiding this comment.
Is the reporting and the progress updates accurate if the flow is:
for pod in pods:
run each collector
or should it be:
for collector in collectors:
run in each pod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Please include a summary of the change or what problem it solves. Please also include relevant motivation and context.
Checklist
Does this PR introduce a breaking change?