Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cpuArchitecture filter to nodeResources collector #930

Merged
merged 8 commits into from
Dec 29, 2022
Merged

add cpuArchitecture filter to nodeResources collector #930

merged 8 commits into from
Dec 29, 2022

Conversation

adamancini
Copy link
Member

@adamancini adamancini commented Dec 23, 2022 •
edited
Loading

Description, Motivation and Context

support filtering nodes based on CPU architecture in nodeResources analyzer

resolves #805

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@adamancini adamancini mentioned this pull request Dec 23, 2022
Merged
@adamancini adamancini added type::feature New feature or request echoes/effort: S Low effort changes (M * 0.5) labels Dec 23, 2022
@adamancini adamancini changed the title Ada/cpu arch analyzer add cpuArchitecture filter to nodeResources collector Dec 23, 2022
@adamancini adamancini marked this pull request as ready for review December 28, 2022 15:54
@adamancini adamancini requested a review from a team as a code owner December 28, 2022 15:54
banjoh
banjoh reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

pkg/analyze/node_resources.go Outdated Show resolved Hide resolved
@banjoh
Copy link
Member

banjoh commented Dec 28, 2022

Run make generate

@adamancini
Copy link
Member Author

Run make generate

done

@adamancini adamancini requested a review from banjoh December 28, 2022 19:50
xavpaice
xavpaice previously requested changes Dec 28, 2022
View reviewed changes
Copy link
Member

@xavpaice xavpaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs make schemas in order to pass tests

banjoh
banjoh approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it :)

@banjoh
Copy link
Member

banjoh commented Dec 29, 2022 •
edited
Loading

Run make generate

done

I meant make schemas which you have done ;)

@adamancini adamancini merged commit 0f2892c into main Dec 29, 2022
@adamancini adamancini deleted the ada/cpu-arch-analyzer branch December 29, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banjoh banjoh banjoh approved these changes

@xavpaice xavpaice xavpaice left review comments

Assignees
No one assigned
Labels
echoes/effort: S Low effort changes (M * 0.5) type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new check to verify if the platform is supported and node affinity criteria
3 participants
@adamancini @banjoh @xavpaice