-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle pickle in BaseUrlSession
for base_url
#376
Handle pickle in BaseUrlSession
for base_url
#376
Conversation
- Add `base_url` when `__getstate__` is called - Try to take `base_url` when `__setstate__` is called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add something to the change log too?
Should I put in 1.0.0 section? |
Nope. Create a 1.1.0 section. 1.0 was already released |
Can you look into the test failures? I don't see them in main |
Done, but it's quite weird that two of the content length of the recorded data are wrong: For example, httpbin:
|
Things failing on 3.12 are failing on a deprecation warning that needs to be fixed elsewhere. Thanks for working through this! |
base_url
when__getstate__
is calledbase_url
when__setstate__
is calledResolve #375