reenable tagging

rerun-io · Dec 17, 2024 · 45d4219 · 45d4219
1 parent 0387be2
commit 45d4219
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 58 deletions.
diff --git a/crates/store/re_chunk/src/chunk.rs b/crates/store/re_chunk/src/chunk.rs
@@ -67,8 +67,6 @@ impl ChunkComponents {
         component_desc: ComponentDescriptor,
         list_array: Arrow2ListArray<i32>,
     ) -> Option<Arrow2ListArray<i32>> {
-        // TODO(cmc): revert me
-        let component_desc = component_desc.untagged();
         self.0
             .entry(component_desc.component_name)
             .or_default()

diff --git a/docs/snippets/all/descriptors/descr_builtin_archetype.rs b/docs/snippets/all/descriptors/descr_builtin_archetype.rs
@@ -56,38 +56,20 @@ fn check_tags(rec: &rerun::RecordingStream) {
             .collect::<Vec<_>>();
         descriptors.sort();
 
-        // TODO(cmc): revert me
-        // let expected = vec![
-        //     ComponentDescriptor {
-        //         archetype_name: None,
-        //         archetype_field_name: None,
-        //         component_name: "rerun.components.Points3DIndicator".into(),
-        //     },
-        //     ComponentDescriptor {
-        //         archetype_name: Some("rerun.archetypes.Points3D".into()),
-        //         archetype_field_name: Some("positions".into()),
-        //         component_name: "rerun.components.Position3D".into(),
-        //     },
-        //     ComponentDescriptor {
-        //         archetype_name: Some("rerun.archetypes.Points3D".into()),
-        //         archetype_field_name: Some("radii".into()),
-        //         component_name: "rerun.components.Radius".into(),
-        //     },
-        // ];
         let expected = vec![
             ComponentDescriptor {
                 archetype_name: None,
                 archetype_field_name: None,
                 component_name: "rerun.components.Points3DIndicator".into(),
             },
             ComponentDescriptor {
-                archetype_name: None,
-                archetype_field_name: None,
+                archetype_name: Some("rerun.archetypes.Points3D".into()),
+                archetype_field_name: Some("positions".into()),
                 component_name: "rerun.components.Position3D".into(),
             },
             ComponentDescriptor {
-                archetype_name: None,
-                archetype_field_name: None,
+                archetype_name: Some("rerun.archetypes.Points3D".into()),
+                archetype_field_name: Some("radii".into()),
                 component_name: "rerun.components.Radius".into(),
             },
         ];

diff --git a/docs/snippets/all/descriptors/descr_custom_archetype.rs b/docs/snippets/all/descriptors/descr_custom_archetype.rs
@@ -104,38 +104,20 @@ fn check_tags(rec: &rerun::RecordingStream) {
             .collect::<Vec<_>>();
         descriptors.sort();
 
-        // TODO(cmc): revert me
-        // let expected = vec![
-        //     ComponentDescriptor {
-        //         archetype_name: None,
-        //         archetype_field_name: None,
-        //         component_name: "user.CustomPoints3DIndicator".into(),
-        //     },
-        //     ComponentDescriptor {
-        //         archetype_name: Some("user.CustomPoints3D".into()),
-        //         archetype_field_name: Some("colors".into()),
-        //         component_name: "rerun.components.Color".into(),
-        //     },
-        //     ComponentDescriptor {
-        //         archetype_name: Some("user.CustomPoints3D".into()),
-        //         archetype_field_name: Some("custom_positions".into()),
-        //         component_name: "user.CustomPosition3D".into(),
-        //     },
-        // ];
         let expected = vec![
             ComponentDescriptor {
                 archetype_name: None,
                 archetype_field_name: None,
-                component_name: "rerun.components.Color".into(),
+                component_name: "user.CustomPoints3DIndicator".into(),
             },
             ComponentDescriptor {
-                archetype_name: None,
-                archetype_field_name: None,
-                component_name: "user.CustomPoints3DIndicator".into(),
+                archetype_name: Some("user.CustomPoints3D".into()),
+                archetype_field_name: Some("colors".into()),
+                component_name: "rerun.components.Color".into(),
             },
             ComponentDescriptor {
-                archetype_name: None,
-                archetype_field_name: None,
+                archetype_name: Some("user.CustomPoints3D".into()),
+                archetype_field_name: Some("custom_positions".into()),
                 component_name: "user.CustomPosition3D".into(),
             },
         ];

diff --git a/docs/snippets/all/descriptors/descr_custom_component.rs b/docs/snippets/all/descriptors/descr_custom_component.rs
@@ -59,18 +59,10 @@ fn check_tags(rec: &rerun::RecordingStream) {
             .collect::<Vec<_>>();
         descriptors.sort();
 
-        // TODO(cmc): revert me
-        // let expected = vec![
-        //     ComponentDescriptor {
-        //         archetype_name: Some("user.CustomArchetype".into()),
-        //         archetype_field_name: Some("custom_positions".into()),
-        //         component_name: "user.CustomPosition3D".into(),
-        //     }, //
-        // ];
         let expected = vec![
             ComponentDescriptor {
-                archetype_name: None,
-                archetype_field_name: None,
+                archetype_name: Some("user.CustomArchetype".into()),
+                archetype_field_name: Some("custom_positions".into()),
                 component_name: "user.CustomPosition3D".into(),
             }, //
         ];