Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable tagging post-0.21 release #8500

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reenable tagging post-0.21 release #8500

wants to merge 2 commits into from

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Dec 17, 2024

Title.

  • DNM: requires 0.21 released first

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages labels Dec 17, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Dec 17, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12370930491

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 54dfa2d https://rerun.io/viewer/pr/8500 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc force-pushed the cmc/reenable_tagging_post_021 branch from 45d4219 to 928b523 Compare December 17, 2024 10:40
Base automatically changed from cmc/disable_tagging_021 to main December 17, 2024 10:43
@teh-cmc teh-cmc force-pushed the cmc/reenable_tagging_post_021 branch from 928b523 to 54dfa2d Compare December 17, 2024 10:43
@teh-cmc teh-cmc added do-not-merge Do not merge this PR and removed do-not-merge Do not merge this PR labels Dec 18, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Dec 18, 2024 •
edited
Loading

abey79
abey79 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to face the consequences 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @abey79