Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-bindgen to 0.2.87 #2406

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Update wasm-bindgen to 0.2.87 #2406

merged 1 commit into from
Jun 13, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Jun 13, 2023

It contains this important fix for Rust 1.70: rustwasm/wasm-bindgen#3463

I tested the web viewer, and it works.

Checklist

PR Build Summary: https://build.rerun.io/pr/2406

Docs preview: https://rerun.io/preview/eebb149/docs
Examples preview: https://rerun.io/preview/eebb149/examples

@emilk emilk added 🕸️ web regarding running the viewer in a browser dependencies concerning crates, pip packages etc labels Jun 13, 2023
@Wumpf Wumpf self-requested a review June 13, 2023 08:54
@Wumpf
Copy link
Member

Wumpf commented Jun 13, 2023

waiting for ci to finish then trying on my android phone just to be sure

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my android firefox, android chrome has issues but they are unrelated to this

@Wumpf Wumpf merged commit 2c792ce into main Jun 13, 2023
@Wumpf Wumpf deleted the emilk/update-wasm-bindgen-0.2.87 branch June 13, 2023 09:18
emilk added a commit that referenced this pull request Jun 15, 2023
It contains this important fix for Rust 1.70:
rustwasm/wasm-bindgen#3463

I tested the web viewer, and it works.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2406

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/eebb149/docs
Examples preview: https://rerun.io/preview/eebb149/examples
<!-- pr-link-docs:end -->
@emilk emilk mentioned this pull request Jun 15, 2023
3 tasks
@emilk emilk changed the title Update wasm-bindgen to 0.2.87 Update wasm-bindgen to 0.2.87 Jun 15, 2023
@emilk emilk mentioned this pull request Jun 15, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants