-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "Open file" dialog on Web #3068
Conversation
a7e43c1
to
0763c21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to have!
{ | ||
use re_ui::UICommandSender; | ||
use re_ui::UICommandSender as _; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the trait import is needed for send_ui
. I added the as _
because of https://github.com/rerun-io/rerun/blob/main/CODE_STYLE.md#style
One annoying thing is that once you have the dialog up, it seems that you can't escape out of it. The only way is to actually load a RRD file. |
I can, by pressing "OK", which is quite confusing. I filed an issue: |
Oh yeah, that worked in safari as well. My brain forbid me to even think of clicking a disabled button. |
I guess that can be dealt with using CSS. |
Yep I consider the css elements ids a part of public API, and they have same stability guaranties as any other Rust function in the crate. So style it hewer you see fit for your app. That being said the button looks weird, I'm pretty sure I don't style it, it's just a |
It looks "disabled" because of our global css on that page. We set the default font color to a very light one:
Which in combination with the light background produces this effect. We'll fix it on our side. :) |
Future work
We should maybe use
AsyncFileDialog
on native tooChecklist