Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vercel redeploy #4119

Merged
merged 9 commits into from
Nov 1, 2023
Merged

Fix vercel redeploy #4119

merged 9 commits into from
Nov 1, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Nov 1, 2023 •
edited by github-actions bot
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jprochazk jprochazk added ⛴ release Related to shipping or publishing exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Nov 1, 2023
@jprochazk
Copy link
Member Author

Now it's clear what the problem was: https://github.com/rerun-io/rerun/actions/runs/6721155529/job/18266251435#step:3:13

@jprochazk
Copy link
Member Author

Seems to work after giving it a fresh token

@jprochazk jprochazk marked this pull request as ready for review November 1, 2023 14:49
@emilk emilk self-requested a review November 1, 2023 15:04
emilk
emilk approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the error reporting around this!

.github/actions/deploy-vercel/index.mjs

console.log(`Triggering redeploy`);
await client.redeploy(team.id, deployment.uid, "landing");
info`Fetching team "${teamName}"`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What magic syntax is this O.o

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagged template literal

@jprochazk
Copy link
Member Author

One last thing: Added the ability to run the deployment manually given all the same inputs as the CI, via manual.mjs (making things work local-first 🙂)

@jprochazk jprochazk merged commit 18309aa into main Nov 1, 2023
35 checks passed
@jprochazk jprochazk deleted the jan/fix-vercel-redeploy branch November 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ⛴ release Related to shipping or publishing 🚢 CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the release workflow CI failures found during 0.10 release
2 participants
@jprochazk @emilk