Update the remote APIs to take and send a Table #8521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
exclude from changelog
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
zehiko
approved these changes
Dec 18, 2024
| @@ -68,4 +68,7 @@ | |||
| This can be any numpy-compatible array of integers, or a [`pa.Int64Array`][] | |||
| """ | |||
|
|
|||
| MetadataLike: TypeAlias = pa.Array | |||
| TableLike: TypeAlias = Union[pa.Table, pa.RecordBatch, pa.RecordBatchReader] | |||
There was a problem hiding this comment.
nice we can make it generic over all these options.
| let schema = arrow2::datatypes::Schema::from(schema); | ||
|
|
||
| let data = arrow2::chunk::Chunk::new(data); | ||
| // TODO(jleibs): This id name should probably come from `re_protos` |
There was a problem hiding this comment.
(I was thinking about this yesterday and came to the same conclusion. We should put these rerun mandatory fields somewhere so that we can re-use on both sides)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the update APIs to now support multi-recording updates, and generally gives users more direct control over things like the column metadata, etc.