Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single log call in graph examples #8527

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 18, 2024

Makes the graph examples look a lil bit nicer and more compact.

Note that this is a very recent thing that we can do this in Rust 🥳

Also, embedds graph_directed in the examples (this has been done directly on the release branch already)

  • full check passed in order to confirm the example output is still the same (tested this locally but who knows)

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 18, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Dec 18, 2024

@rerun-bot full-check

Copy link

Copy link

github-actions bot commented Dec 18, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
9351b2a https://rerun.io/viewer/pr/8527 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc merged commit fd1adf9 into main Dec 18, 2024
75 of 76 checks passed
@teh-cmc teh-cmc deleted the andreas/more-compact-graph-examples branch December 18, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants