-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSRV to 1.81 #8529
Update MSRV to 1.81 #8529
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12410576658 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Are you expecting the allow
-> expect
migration to be more painful than "just" a massive grep?
@@ -157,21 +157,25 @@ impl ColorTable { | |||
} | |||
|
|||
#[inline] | |||
#[allow(dead_code)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make the color table pub
Oh yes, a lot more painful. A lot of the |
Related
#[allow()]
with#[expect()]
#7485EntityPathFilter
has undefined behavior for sorting #8530What
Update MSRV to 1.81