Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.81 #8529

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Update MSRV to 1.81 #8529

merged 10 commits into from
Dec 19, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 18, 2024

Copy link

github-actions bot commented Dec 18, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
d69b11e https://rerun.io/viewer/pr/8529 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Dec 18, 2024

Latest documentation preview deployed successfully.

Result Commit Link
d69b11e https://landing-5ge7gpjpu-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@emilk emilk marked this pull request as ready for review December 19, 2024 09:19
@emilk
Copy link
Member Author

emilk commented Dec 19, 2024

@rerun-bot full-check

Copy link

@abey79 abey79 self-requested a review December 19, 2024 10:18
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Are you expecting the allow -> expect migration to be more painful than "just" a massive grep?

@@ -157,21 +157,25 @@ impl ColorTable {
}

#[inline]
#[allow(dead_code)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make the color table pub

@emilk
Copy link
Member Author

emilk commented Dec 19, 2024

lgtm!

Are you expecting the allow -> expect migration to be more painful than "just" a massive grep?

Oh yes, a lot more painful. A lot of the allow:s are there only for certain targets (e.g. wasm32)

@emilk emilk merged commit 5a54e08 into main Dec 19, 2024
9 of 10 checks passed
@emilk emilk deleted the emilk/rust-1.81 branch December 19, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants