Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ./scripts/lint.py ignored all under crates/build #8532

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 18, 2024

No description provided.

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Dec 18, 2024
@emilk emilk changed the title Fix: ./scripts/lint.py excluded everything under crates/build Fix: ./scripts/lint.py ignored all under crates/build Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
b3c1ddf https://rerun.io/viewer/pr/8532 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haaaaaaaaa, so that's why github search never worked for things in build/ 🫠

@emilk emilk merged commit 905c2fc into main Dec 18, 2024
36 of 38 checks passed
@emilk emilk deleted the emilk/fix-linting-of-build-crates branch December 18, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants