Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trait SizeBytes to new crate re_byte_size #8544

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 19, 2024

This is so that I can move fn arrow_ui (which depend on SizeBytes) into re_ui, as part of improved testing of it before migrating it to arrow1.

And re_byte_size sounds nicer than re_sizes_bytes. Maybe we should rename the trait to ByteSize too.

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
42fe3af https://rerun.io/viewer/pr/8544 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk marked this pull request as ready for review December 19, 2024 13:51
@teh-cmc teh-cmc merged commit 8ff8336 into main Dec 20, 2024
27 checks passed
@teh-cmc teh-cmc deleted the emilk/re_byte_size branch December 20, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants