Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve coroio linking issue #2

Merged
merged 1 commit into from
Jan 27, 2024
Merged

resolve coroio linking issue #2

merged 1 commit into from
Jan 27, 2024

Conversation

Saad-Hussain31
Copy link
Contributor

No description provided.

@Saad-Hussain31 Saad-Hussain31 changed the title resolve corio linking issue resolve coroio linking issue Jan 27, 2024
@resetius resetius merged commit 4b52b0d into resetius:master Jan 27, 2024
1 check passed
@resetius
Copy link
Owner

Thanks

@resetius
Copy link
Owner

Pls could you update the project with submodules and check again?
liburing dependency should be resolved via cmake dependencies in the following way:

target_link_libraries(coroio PUBLIC ${URING_LIBRARIES} ${OPENSSL_LIBRARIES})
...
target_link_libraries(miniraft PUBLIC coroio)

coroio depends on liburing, miniraft depends on coroio as well as on liburing. As a result an executable will depend on liburing.

@Saad-Hussain31
Copy link
Contributor Author

just checked. building fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saad-Hussain31 @resetius