test: minor change in test case

resilient-tech · Dec 13, 2024 · 5131f45 · 5131f45
1 parent 36966a1
commit 5131f45
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/india_compliance/gst_india/overrides/test_purchase_invoice.py b/india_compliance/gst_india/overrides/test_purchase_invoice.py
@@ -79,8 +79,9 @@ def test_validate_invoice_length(self):
         setattr(pinv, "__newname", "INV/2022/00001/asdfsadg")  # NOQA
         pinv.meta.autoname = "prompt"
 
-        self.assertRaisesRegex(
-            frappe.exceptions.ValidationError,
+        pinv.save()
+
+        self.assertEqual(
+            frappe.parse_json(frappe.message_log[-1]).get("message"),
             "Transaction Name must be 16 characters or fewer to meet GST requirements",
-            pinv.save,
         )
diff --git a/india_compliance/gst_india/utils/__init__.py b/india_compliance/gst_india/utils/__init__.py
@@ -955,11 +955,10 @@ def validate_invoice_number(doc, throw=True):
             " only contain alphanumeric characters, dash (-) and slash (/) to meet GST requirements"
         )
 
-    if doc.doctype == "Purchase Invoice":
-        frappe.msgprint(message, title=title)
-        return
+    if doc.doctype == "Sales Invoice":
+        frappe.throw(message, title=title)
 
-    frappe.throw(message, title=title)
+    frappe.msgprint(message, title=title)
 
 
 def handle_server_errors(settings, doc, document_type, error):