Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Common Taxes for BOE and Subcontracting (backport #2515) #2802

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Nov 29, 2024

This is a backport of pull request #2515.

Huly®: IC-2928

fix: Common Taxes for BOE and Subcontracting
@Ninad1306 Ninad1306 requested a review from vorasmit November 29, 2024 09:58
@Ninad1306 Ninad1306 assigned Ninad1306 and vorasmit and unassigned Ninad1306 Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.75%. Comparing base (65289ea) to head (a3c598e).
Report is 28 commits behind head on version-15-hotfix.

Files with missing lines Patch % Lines
...st_india/report/gstr_3b_details/gstr_3b_details.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           version-15-hotfix    #2802      +/-   ##
=====================================================
- Coverage              59.96%   59.75%   -0.22%     
=====================================================
  Files                    123      122       -1     
  Lines                  12114    12035      -79     
=====================================================
- Hits                    7264     7191      -73     
+ Misses                  4850     4844       -6     
Files with missing lines Coverage Δ
...e/gst_india/doctype/bill_of_entry/bill_of_entry.py 83.88% <100.00%> (-2.81%) ⬇️
...gst_india/doctype/gstr_3b_report/gstr_3b_report.py 84.59% <100.00%> (ø)
...dia_compliance/gst_india/utils/taxes_controller.py 92.30% <100.00%> (+1.17%) ⬆️
...st_india/report/gstr_3b_details/gstr_3b_details.py 38.58% <0.00%> (ø)

Impacted file tree graph

ic_taxes = frappe.qb.DocType("India Compliance Taxes and Charges")

return (
get_taxes_query(docs, doctype, boe_taxes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may also be used where this table doesn't exist. I guess we should make provision for the same.

@vorasmit vorasmit merged commit 1b3f9e2 into resilient-tech:version-15-hotfix Dec 5, 2024
12 of 13 checks passed
@Ninad1306 Ninad1306 deleted the merge_boe_taxes_backport branch December 5, 2024 11:29
@india-compliance-bot
Copy link
Collaborator

🎉 This PR is included in version 15.14.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants