-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle Actions
button for smaller screens
#2806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarvora
force-pushed
the
actions-button-style
branch
2 times, most recently
from
December 2, 2024 05:10
d522e78
to
b9f1bbb
Compare
vorasmit
reviewed
Dec 3, 2024
india_compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.js
Outdated
Show resolved
Hide resolved
UI compatibility for backport? |
Abdeali099
force-pushed
the
actions-button-style
branch
from
December 4, 2024 05:16
b9f1bbb
to
6c9b8b6
Compare
Abdeali099
force-pushed
the
actions-button-style
branch
from
December 5, 2024 06:03
17db71f
to
9c2f95a
Compare
UI is compatible, but require manual backport |
Abdeali099
changed the title
fix: Hide
fix: handle Dec 5, 2024
Actions
text on small screensActions
button for smaller screens
Abdeali099
force-pushed
the
actions-button-style
branch
from
December 5, 2024 13:50
4dd967a
to
dc8b3e5
Compare
Abdeali099
force-pushed
the
actions-button-style
branch
from
December 5, 2024 14:27
dc8b3e5
to
d286860
Compare
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
* fix: Hide `Actions` text on small screens * fix: Handle translation * fix: Check translated text for Actions group button * fix: Show dot-horizontal icon on smaller screen for Actions * fix: Check button element innerText for Actions * fix: Remove `Actions` from page actions menu * fix: Hide custom `Actions` in smaller screen (cherry picked from commit a82287c) # Conflicts: # india_compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.js
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
* fix: Hide `Actions` text on small screens * fix: Handle translation * fix: Check translated text for Actions group button * fix: Show dot-horizontal icon on smaller screen for Actions * fix: Check button element innerText for Actions * fix: Remove `Actions` from page actions menu * fix: Hide custom `Actions` in smaller screen (cherry picked from commit a82287c)
This was referenced Dec 5, 2024
vorasmit
added a commit
that referenced
this pull request
Dec 5, 2024
…tfix/pr-2806 fix: handle `Actions` button for smaller screens (backport #2806)
vorasmit
added a commit
that referenced
this pull request
Dec 5, 2024
…tfix/pr-2806 fix: handle `Actions` button for smaller screens (backport #2806)
india-compliance-bot
added a commit
that referenced
this pull request
Dec 6, 2024
## [14.30.9](v14.30.8...v14.30.9) (2024-12-06) ### Bug Fixes * add filter for purchase doctype to purchase reco tool ([e1b7e97](e1b7e97)) * allow setting pos from shipping address based on account settings ([ab03de5](ab03de5)) * auto set link doctype and docname in address dialog for lead ([85f6041](85f6041)) * auto suggest creation of debit note for CDNR when creating a purchase ([4e1bac7](4e1bac7)) * better filters for match status and actions performed ([2b686ba](2b686ba)) * better matches for CDNR by ignoring the difference in bill date ([293a7ff](293a7ff)) * correct option for field GST Inward Supply ([5717ccd](5717ccd)) * do not check gst category for setting Place of supply ([540c6d2](540c6d2)) * handle `Actions` button for smaller screens ([#2806](#2806)) ([8eb246e](8eb246e)) * minor UI change ([aa99dfc](aa99dfc)) * show correct number of documents for purchase recon tool for missing in 2A/2B ([963c956](963c956)) * show doctype name in detail comparision ([af8eb24](af8eb24)) * support use of customer shipping address instead of company gstin for place of supply ([6aa0244](6aa0244)) * Take up Company type from GSTIN portal automatically ([#2770](#2770)) ([2065676](2065676)) * test case ([322ad85](322ad85))
india-compliance-bot
added a commit
that referenced
this pull request
Dec 6, 2024
## [15.14.3](v15.14.2...v15.14.3) (2024-12-06) ### Bug Fixes * add filter for purchase doctype to purchase reco tool ([cf23a9d](cf23a9d)) * always check for company gstin ([65289ea](65289ea)) * auto set link doctype and docname in address dialog for lead ([21fb4d3](21fb4d3)) * auto suggest creation of debit note for CDNR when creating a purchase ([4645e42](4645e42)) * avoid duplicate taxes when same name ([b0c25eb](b0c25eb)) * better filters for match status and actions performed ([96df79c](96df79c)) * better matches for CDNR by ignoring the difference in bill date ([950f0d4](950f0d4)) * correct option for field GST Inward Supply ([a413723](a413723)) * handle `Actions` button for smaller screens ([#2806](#2806)) ([bf2b241](bf2b241)) * Only Validate Taxes if e-Waybill Applicable ([#2803](#2803)) ([a679251](a679251)) * resolved conflicts ([e8c5a46](e8c5a46)) * set supplier ([368a8f3](368a8f3)) * show correct number of documents for purchase recon tool for missing in 2A/2B ([d7d0fe8](d7d0fe8)) * show doctype name in detail comparision ([d8447fa](d8447fa)) * Take up Company type from GSTIN portal automatically ([#2770](#2770)) ([adef4e0](adef4e0)) * update custom fields ([5460864](5460864))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Huly®: IC-2932