fix: failing test case of payment entry #2835
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanket322
force-pushed
the
regional_override_test_case
branch
from
957fdbe to
3051b0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2835 +/- ##
========================================
Coverage 60.16% 60.16%
========================================
Files 122 122
Lines 12000 12000
========================================
Hits 7220 7220
Misses 4780 4780
|
vorasmit
added a commit
to vorasmit/ic
that referenced
this pull request
Dec 12, 2024
sagarvora
added a commit
that referenced
this pull request
Dec 12, 2024
fix: change regional override as per erpnext changes (backport #2835)
india-compliance-bot
added a commit
that referenced
this pull request
Dec 12, 2024
## [15.14.4](v15.14.3...v15.14.4) (2024-12-12) ### Bug Fixes * add documentation links in help ([#2810](#2810)) ([0d868c7](0d868c7)) * change regional override as per erpnext changes (backport [#2835](#2835)) ([34aa57d](34aa57d)) * correct categorisation of is_export and fetching taxes accordingly ([5f1850c](5f1850c)) * Error Handling for download of GSTR2A/2B ([#2832](#2832)) ([52dba38](52dba38)) * **patch:** ignore validate when creating item tax template ([#2831](#2831)) ([caf8e75](caf8e75)) * taxable value for invoice without qty and value ([46af03a](46af03a)) * use bulk insert to ignore validations ([4448e1a](4448e1a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_advance_payment_entries_for_regional function was failing because ERPNext passes an additional parameter called default_advance_account
erpnext pr : #44545
Huly®: IC-2961