Adding support for wildcard keys. #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excluding key with wildcard. Escaping * for wildcard match. Using #include for wildcard character comparison. Fixing instance variable name. Merging wildcard keys to original configuration. Fixing wildcard key hash. Removing wildcard key after hash is merged.
| end | ||
|
|
||
| def config_hash_for_wildcard_keys | ||
| hash = {} |
There was a problem hiding this comment.
This would be a little cleaner..
{}.tap do |hash|
wildcard_keys.each do |wildcard_key|
hash[wildcard_key] = 1
end
end
|
I think this approach is obsoleted by #85. Thanks for your contribution! |
|
Agreed. Thank you for getting around to closing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the ability to use a wildcard key.
For Example: a key "queue*" will spin up a worker for each matching queue in Resque.queues. So, if the application has queued up jobs on queues queue1, queue2 and queue3, a worker will be created for each of those queues.