Honour repo.FileMode permissions #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
fix-file-permissions
branch
from
54a9ed4
to
51ab8e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
ioutil.TempFilealways creates files with permissions0600. Use a custom method to be able to honor theFileModeconfigured inrepo.go. Note that this is not a user visible change as the option is not exposed anywhere.Was the change discussed in an issue or in the forum before?
See #166.
Checklist
[ ] I have added documentation for the changes (in the manual)[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits