Include request_id in handshake error responses #839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838
When an exception is thrown inside
handshake
(server/src/auth.js) it is currently caught inerror_wrap_socket
(server/src/client.js) where the originating request'srequest_id
is unknown. Failed handshake requests will therefore respond withrequest_id: null
This change is to instead return a rejected promise, which will be caught in the catch clause inside
handle_handshake
(server/src/client.js), from where a JSON response is sent including therequest_id
.This change is