Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins #865

Open
wants to merge 137 commits into
base: next
Choose a base branch
from
Open

Plugins #865

wants to merge 137 commits into from

Conversation

Tryneus
Copy link
Member

@Tryneus Tryneus commented Jan 26, 2017

This is a work in progress, but eclipses #760 - this is a fork from that branch to my personal repo.

Several big things remain to do:

  • Replace the CLI with one based on Express
  • Integrate auth plugins
  • Lots of tests
  • A complete changelog

The Horizon server has been completely revamped, so any users who directly embedded the server will need non-trivial code changes. The client is relatively unchanged, it was a goal to make it as painless as possible of an upgrade in the frontend. Still, a few backwards-incompatibilities surfaced:

  • argument validation is now performed server-side, so errors are asynchronous
  • batch write errors are no longer an instance of Error, but an {error: ''} object
  • there are no more ordering constraints for chaining terms
  • no state: synced documents
  • the unconnected initial horizon state is gone, replaced by disconnected
  • fewer restrictions on above/below/order - you can now specify the same key in findAll without an error (I doubt there's much of a use case for this)
  • collections cannot start with 'hz_'

This change is Reviewable

@deontologician deontologician mentioned this pull request Mar 11, 2017
@lgleim
Copy link

lgleim commented Mar 12, 2017

@Tryneus Are you still commited to completing this refactoring process? Either way, could you please give a quick heads up re status so this work can be picked up by someone else otherwise?

@sp90
Copy link

sp90 commented Apr 17, 2017

Whats the status on this?

@madwill
Copy link

madwill commented Dec 18, 2017

Hi everyone, i'm interested in trying this version of horizon. I have forked @Tryneus repos and build the grey_plugins branch which compile ok.

I understand it seems to be using CircleCi for continuous integration. I would be interested in some pointers on how to build and publish the package including client/server together.

If its somewhat complicated i guess we could publish client and server separately.

Thank you very much for your time

William

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants