Fix / suppress psalm issues

revoltphp · Mar 19, 2024 · 402bd90 · 402bd90
1 parent be1891f
commit 402bd90
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 3 deletions.
diff --git a/examples/generate-yes.php b/examples/generate-yes.php
@@ -24,7 +24,7 @@
     $r = \fwrite($stdout, $data);
 
     // nothing could be written despite being writable => closed
-    if ($r === 0) {
+    if ($r === 0 || $r === false) {
         EventLoop::cancel($watcher);
         \stream_set_blocking($stdout, true);
         \fclose($stdout);

diff --git a/psalm.xml b/psalm.xml
@@ -65,6 +65,12 @@
                 <directory name="src"/>
             </errorLevel>
         </UnsupportedPropertyReferenceUsage>
+
+        <PossiblyInvalidArgument>
+            <errorLevel type="suppress">
+                <directory name="examples" />
+            </errorLevel>
+        </PossiblyInvalidArgument>
     </issueHandlers>
 
     <stubs>

diff --git a/src/EventLoop/Driver/StreamSelectDriver.php b/src/EventLoop/Driver/StreamSelectDriver.php
@@ -277,7 +277,7 @@ private function selectStreams(array $read, array $write, float $timeout): void
             }
 
             /** @var array<int, resource>|null $except */
-            if ($except) {
+            if ($except !== null) {
                 foreach ($except as $key => $socket) {
                     $write[$key] = $socket;
                 }

diff --git a/src/EventLoop/DriverFactory.php b/src/EventLoop/DriverFactory.php
@@ -42,6 +42,7 @@ public function create(): Driver
             return new StreamSelectDriver();
         })();
 
+        /** @psalm-suppress RiskyTruthyFalsyComparison */
         if (\getenv("REVOLT_DRIVER_DEBUG_TRACE")) {
             return new TracingDriver($driver);
         }
@@ -56,6 +57,7 @@ private function createDriverFromEnv(): ?Driver
     {
         $driver = \getenv("REVOLT_DRIVER");
 
+        /** @psalm-suppress RiskyTruthyFalsyComparison */
         if (!$driver) {
             return null;
         }

diff --git a/src/EventLoop/Internal/AbstractDriver.php b/src/EventLoop/Internal/AbstractDriver.php
@@ -68,6 +68,7 @@ public function __construct()
     {
         if (\PHP_VERSION_ID < 80117 || \PHP_VERSION_ID >= 80200 && \PHP_VERSION_ID < 80204) {
             // PHP GC is broken on early 8.1 and 8.2 versions, see https://github.com/php/php-src/issues/10496
+            /** @psalm-suppress RiskyTruthyFalsyComparison */
             if (!\getenv('REVOLT_DRIVER_SUPPRESS_ISSUE_10496')) {
                 throw new \Error('Your version of PHP is affected by serious garbage collector bugs related to fibers. Please upgrade to a newer version of PHP, i.e. >= 8.1.17 or => 8.2.4');
             }

diff --git a/src/EventLoop/Internal/ClosureHelper.php b/src/EventLoop/Internal/ClosureHelper.php
@@ -18,7 +18,7 @@ public static function getDescription(\Closure $closure): string
                 $description = $scopeClass->name . '::' . $description;
             }
 
-            if ($reflection->getFileName() && $reflection->getStartLine()) {
+            if ($reflection->getFileName() !== false && $reflection->getStartLine()) {
                 $description .= " defined in " . $reflection->getFileName() . ':' . $reflection->getStartLine();
             }