Clean the state pollution in TestMainView.test_warning with monkeypatch

revsys · Aug 7, 2021 · 851b6d1 · 851b6d1
1 parent d08200d
commit 851b6d1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tests/test_views.py b/tests/test_views.py
@@ -99,7 +99,7 @@ def check_status(self):
         assert response['content-type'] == 'text/html; charset=utf-8'
         assert b'Super Fail!' in response.content
 
-    def test_warning(self, client):
+    def test_warning(self, client, monkeypatch):
         class MyBackend(BaseHealthCheckBackend):
             def check_status(self):
                 raise ServiceWarning('so so')
@@ -110,7 +110,7 @@ def check_status(self):
         assert response.status_code == 500, response.content.decode('utf-8')
         assert b'so so' in response.content, response.content
 
-        HEALTH_CHECK['WARNINGS_AS_ERRORS'] = False
+        monkeypatch.setitem(HEALTH_CHECK, 'WARNINGS_AS_ERRORS', False)
 
         response = client.get(self.url)
         assert response.status_code == 200, response.content.decode('utf-8')