Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade commonmark to avoid minor vulnerability #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rpokorny
Copy link

@rpokorny rpokorny commented Jan 5, 2021

commonmark 0.27.0 has a denial-of-service vulnerability in the form of some inefficient parsing that takes quadratic time, as documented here: commonmark/commonmark.js#172 . This was fixed in commonmark 0.29.1, so this PR upgrades to that version.

This did require some small updates to the tests. It's not clear to me whether those updates were something to be expected or if they are a problem. I suspect they are fine, but please check them closely while reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant