-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of client and cli #88
Open
Cyber1000
wants to merge
24
commits into
rgerganov:master
Choose a base branch
from
Cyber1000:refactoring-client-and-cli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved debug-param to ctor, get/set-methods don't take it anymore
- changed json output of client-classes - added CLI_FORMAT and using it on cli-side - coap/plain_coap: filter, firmware always returned the full dataset - extending --debug for wifi, filters, firmware
(includes firmware and filters as well)
- adjusted cli
- added subset as switch to set_values - added/cleaned up exceptions
- updated examples
Since tests are still running without substantial changes (just refactoring issues), I'm assuming this PR doesn't break anything, thought I'm uncertain if #86 breaks connection with plain_coap. |
|
- print not needed in tests - enhanced formatting of examples.md
Does anything need to happen before this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for using client-classes with something more server-centric (rest-service, mqtt, ...)
Tasks
General information
Changes in clients
Changes in cli
example output of new client classes (see also Examples.md)