Add ports to readme, fix Service

rh-openjdk · Nov 19, 2024 · 8d6cfea · 8d6cfea
1 parent 040ddca
commit 8d6cfea
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/templates/jlink/README.md b/templates/jlink/README.md
@@ -57,13 +57,17 @@ Some suitable test values for the parameters are
  * REF: master
  * CONTEXT_DIR: quarkus-quickstarts/getting-started-3.9.2-uberjar
  * APPNAME: quarkus-quickstart
+ * TARGET_PORT: 8080
+ * SERVICE_PORT: 8080
 
         oc process \
             -p JDK_VERSION=17 \
             -p APP_URI=https://github.com/jboss-container-images/openjdk-test-applications \
             -p REF=master \
             -p CONTEXT_DIR=quarkus-quickstarts/getting-started-3.9.2-uberjar \
             -p APPNAME=quarkus-quickstart \
+            -p TARGET_PORT=8080 \
+            -p SERVICE_PORT=8080 \
             templates/jlink-app-template \
             | oc create -f -
 

diff --git a/templates/jlink/jlinked-app.yaml b/templates/jlink/jlinked-app.yaml
@@ -31,6 +31,11 @@ parameters:
   required: true
 - description: Target port for the created Route
   name: TARGET_PORT
+  value: "8080"
+  required: true
+- description: Port for the created Service to listen on
+  name: SERVICE_PORT
+  value: "8181"
   required: true
 message: "... The GitHub webhook secret is ${GITHUB_WEBHOOK_SECRET} ..."
 ##############################################################################
@@ -267,8 +272,9 @@ objects:
       app: ${APPNAME}-jlinked-app
     ports:
       - protocol: TCP
-        port: 80
-        targetPort: 8080
+        name: target-${TARGET_PORT}-tcp
+        port: ${{SERVICE_PORT}}
+        targetPort: ${{TARGET_PORT}}
 - apiVersion: route.openshift.io/v1
   kind: Route
   metadata: