[OPENJDK-2145] Update/add usage: labels to UBI8 images #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a usage: label to JDK11-runtime and JDK8-runtime, pointing at <https://jboss-container-images.github.io/openjdk/>, which is probably the best option for the time being. We don't have specific Red Hat customer documentation for runtime images. Alter the usage: label for JDK17 to <https://jboss-container-images.github.io/openjdk/>, as the old value was for OpenShift 3.x era documentation. Adjust the usage: label for JDK11 to a fixed URI for the same document (It changed at some point in the past and we didn't notice sooner.) For all UBI8 images, additionally define a second label org.opencontainers.image.documentation with the same value, following the OpenContainers Spec, Pre-Defined Annotation Keys: <https://specs.opencontainers.org/image-spec/annotations/> Signed-off-by: Jonathan Dowland <[email protected]>
jerboaa
reviewed
Sep 6, 2023
jerboaa
reviewed
Sep 6, 2023
Use the upstream documentation URI for all images. Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
force-pushed
the
OPENJDK-2145-ubi8-usage-label
branch
from
526d1cc to
ffb7761
Compare
jerboaa
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OPENJDK-2145
Add a usage: label to JDK11-runtime and JDK8-runtime, pointing at https://jboss-container-images.github.io/openjdk/, which is probably the best option for the time being. We don't have specific Red Hat customer documentation for runtime images.
Alter the usage: label for JDK17 to
https://jboss-container-images.github.io/openjdk/, as the old value was for OpenShift 3.x era documentation.
Adjust the usage: label for JDK11 to a fixed URI for the same document (It changed at some point in the past and we didn't notice sooner.)
For all UBI8 images, additionally define a second label org.opencontainers.image.documentation with the same value, following the OpenContainers Spec, Pre-Defined Annotation Keys: https://specs.opencontainers.org/image-spec/annotations/