[OPENJDK-2411] JDK21 images for UBI8 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is/was used in order to let non-privileged scripts adjust the running user's GECOS field information, by re-directing lookups from /etc/passwd to $HOME/passwd. See OPENJDK-312. More modern container runtimes (e.g. CRI-O) now update the GECOS for the running user. Signed-off-by: Jonathan Dowland <[email protected]>
Define environment variables capturing the values for the user's name (USER), uid (UID) and user-name/comment/gecos (GECOS, see passwd(5)) in the jboss.container.user module. Replace hard-coded references to those values in scripts across all the other modules. For those modules which now use these variables, add an explicit dependency on jboss.container.user if it wasn't already present. The primary reason for this change is to reduce the delta between the ubi8 and ubi9 branches, which will avoid merge conflicts for future backports from ubi9 to ubi8. The secondary reason is to reduce the risk of a discrepancy for the values across the scripts. Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
It is not useful to test for the mere presence of the 'release' label, since we inherit it from our base image. It's not especially helpful to check architecture=x86_64 either, which rules out running the test suit on any other architecture. Signed-off-by: Jonathan Dowland <[email protected]>
Don't test for 'release' or 'architecture' labels which we don't set in our image sources anyway. Check for strings in the values of the 'version' and 'name' labels, to be sure we've set them and not just inherited them. Split the label-check test into those which apply to all images, and those which are builder-only. Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
|
I am doing a round of scratch builds for these and running the behave test suite locally. |
all passed |
jerboaa
approved these changes
Nov 9, 2023
| - name: jboss.container.openjdk.jdk | ||
| version: "21" | ||
| - name: jboss.container.maven | ||
| version: "3.8.17" |
There was a problem hiding this comment.
Good catch. At the moment there is no maven-openjdk21 RPM package, which would be what 3.8.21 should install (once the module exists), but we expect there to be in the future. So I think for now it's ok to use the 17 one in conjunction with singleton-jdk.
There was a problem hiding this comment.
@jmtd is there a ticket to track the creation of maven-openjdk21?
There was a problem hiding this comment.
There is for RHEL 9.4 (RHEL-13046), but not (yet) for 8.10. I asked the filer of the former whether they'd like me to clone for the latter and haven't yet had a response.
Signed-off-by: Jonathan Dowland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OPENJDK-2411