Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-2722] Move behave tests to relevant modules #448

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

jhuttana
Copy link
Contributor

Could you please review the changes?

Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@jhuttana jhuttana requested a review from jmtd February 17, 2024 10:09
Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules/jvm is not a module in the ubi8 tree -- within it are two modules modules/jvm/api and modules/jvm/bash. Please move the tests from modules/jvm/tests to modules/jvm/api and confirm that they are collected when invoking cekit test.

Please adjust the tagging for gc.feature so it applies to all the ubi8 images (i.e. use @ubi8. I noticed this problem in passing; you have not introduced it in this PR)

modules/s2i/core is not a module; please move modules/s2i/core/tests to modules/s2i/core/api.

Please confirm that the same number of tests run for a builder image and for a runtime image before/after this PR.

Thanks!

Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@jhuttana
Copy link
Contributor Author

jhuttana commented Mar 1, 2024

I have checked the test results Before and After this PR.

Before

$ cekit --descriptor ubi8-openjdk-17.yaml test --image ubi8/openjdk-17 behave
	.
	.
	.
	13 features passed, 0 failed, 2 skipped
	52 scenarios passed, 0 failed, 40 skipped
	141 steps passed, 0 failed, 125 skipped, 0 undefined
	Took 457m39.723s

$ cekit --descriptor ubi8-openjdk-17-runtime.yaml test --image ubi8/openjdk-17-runtime behave
	.
	.
	.
	5 features passed, 0 failed, 10 skipped
	23 scenarios passed, 0 failed, 69 skipped
	52 steps passed, 0 failed, 214 skipped, 0 undefined
	Took 82m49.656s

After

$ cekit --descriptor ubi8-openjdk-17.yaml test --image ubi8/openjdk-17 behave
	.
	.
	.
	13 features passed, 0 failed, 2 skipped
	52 scenarios passed, 0 failed, 40 skipped
	141 steps passed, 0 failed, 125 skipped, 0 undefined
	Took 93m36.129s

	$ cekit --descriptor ubi8-openjdk-17-runtime.yaml test --image ubi8/openjdk-17-runtime behave
	.
	.
	.
	6 features passed, 0 failed, 5 skipped
	32 scenarios passed, 0 failed, 27 skipped
	76 steps passed, 0 failed, 88 skipped, 0 undefined
	Took 31m2.252s

The tests in runtime image increased as a result of adding @ubi8 tagging to gc.feature. And I think that is expected.
Otherwise without that @ubi8 tagging change to gc.feature the results were same.

Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmtd jmtd merged commit d167919 into rh-openjdk:ubi8 Mar 4, 2024
8 checks passed
@jhuttana jhuttana deleted the re-org-tests-ubi8 branch March 13, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants