Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-2722] Create a dummy module.yaml to move openjdk.feature behave test to module/jdk/tests/features #457

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jhuttana
Copy link
Contributor

Could you please review the changes?
I have locally tried a sample test from openjdk.feature and it is picked up successfully

$ cekit --descriptor ubi8-openjdk-17.yaml test --image ubi8/openjdk-17 behave --name 'Ensure LANG is defined and contains UTF-8'
2024-03-13 13:44:35,069 tools.py:465        INFO  You are running on known platform: Fedora Linux 39 (Workstation Edition)
2024-03-13 13:44:35,070 tools.py:626        WARNING The certifi library (https://certifi.io/) was found, depending on the operating system configuration this may result in certificate validation issues. 
2024-03-13 13:44:35,070 tools.py:630        WARNING You can use REQUESTS_CA_BUNDLE environment variable to point to a different certificate bundle if using the certifi provided bundle doesn't work.
2024-03-13 13:44:35,070 tools.py:634        WARNING Certificate Authority (CA) bundle in use: '/etc/pki/tls/certs/ca-bundle.crt'
2024-03-13 13:44:35,070 base.py:108        INFO  Initializing image descriptor...
2024-03-13 13:44:35,081 resource.py:177        WARNING No value found for 'name' in '{"dest": "/tmp/artifacts/", "path": "modules"}' artifact; using auto-generated value of 'modules'
2024-03-13 13:44:35,085 resource.py:231        INFO  Copying resource 'modules'...
2024-03-13 13:44:35,324 base.py:376        INFO  Rendering Dockerfile...
2024-03-13 13:44:35,414 base.py:422        INFO  Rendering help.md page from template /usr/lib/python3.12/site-packages/cekit/generator/../templates/help.jinja
2024-03-13 13:44:35,428 collector.py:44         INFO  Fetching common steps from 'https://github.com/cekit/behave-test-steps.git', ref 'v1'.
Cloning into '/home/jhuttana/workarea/Containers/openjdk/target/test'...
remote: Enumerating objects: 18, done.
remote: Counting objects: 100% (18/18), done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 18 (delta 1), reused 9 (delta 0), pack-reused 0
Receiving objects: 100% (18/18), 14.80 KiB | 87.00 KiB/s, done.
Resolving deltas: 100% (1/1), done.
2024-03-13 13:44:37,226 collector.py:77         INFO  Collecting finished!
USING RUNNER: behave.runner:Runner
Feature: Openshift OpenJDK Jolokia tests # features/image/jolokia.feature:2

Feature: Tests for all openshift images # features/image/openshift.feature:1

@ubi8/openjdk-8 @ubi8/openjdk-11 @ubi8/openjdk-17
Feature: Prometheus agent tests # features/image/prometheus.feature:4

@ubi8/openjdk-11 @ubi8/openjdk-17 @ubi8/openjdk-21
Feature: Openshift OpenJDK-only S2I tests # features/image/java/openjdk_s2i.feature:5

@ubi8/openjdk-8 @ubi8/openjdk-11 @ubi8/openjdk-17 @ubi8/openjdk-21
Feature: Openshift OpenJDK port tests # features/image/java/ports.feature:5

@ubi8/openjdk-8 @ubi8/openjdk-11 @ubi8/openjdk-17 @ubi8/openjdk-21
Feature: Openshift OpenJDK Runtime tests # features/image/java/runtime.feature:5

@ubi8
Feature: Openshift OpenJDK GC tests # features/jboss.container.java.jvm.api/gc.feature:2

Feature: OPENJDK-559 JVM Memory tests # features/jboss.container.java.jvm.api/memory.feature:1

@ubi8/openjdk-8 @ubi8/openjdk-11 @ubi8/openjdk-17 @ubi8/openjdk-21
Feature: Openshift S2I tests # features/jboss.container.java.run/java.security.feature:5

@ubi8/openjdk-8 @ubi8/openjdk-11 @ubi8/openjdk-17 @ubi8/openjdk-21
Feature: Openshift OpenJDK S2I tests # features/jboss.container.maven.s2i/java_s2i_inc.feature:5

@ubi8/openjdk-11 @ubi8/openjdk-17 @ubi8/openjdk-21
Feature: Openshift OpenJDK S2I tests (Quarkus-based) # features/jboss.container.maven.s2i/java_s2i_quarkus.feature:4

Feature: Miscellaneous OpenJDK-related unit tests # features/jboss.container.openjdk/openjdk.feature:3

  @ubi8/openjdk-8 @ubi8/openjdk-8-runtime @ubi8/openjdk-11 @ubi8/openjdk-11-runtime @ubi8/openjdk-17 @ubi8/openjdk-17-runtime
  Scenario: Ensure LANG is defined and contains UTF-8                 # features/jboss.container.openjdk/openjdk.feature:101
    When container is started with args                               # steps/container_steps.py:86 10.763s
      | arg     | value                                                            |
      | command | bash -c "$JAVA_HOME/bin/java -XshowSettings:properties -version" |
    Then available container log should contain file.encoding = UTF-8 # steps/container_steps.py:50
    Then available container log should contain file.encoding = UTF-8 # steps/container_steps.py:50 0.003she logs
2024-03-13 13:44:48,150 container.py:100        INFO  Removing container 'e8bc11796e83af325171442d911f0ff2102804469a4410e62455f9d652038588', 1 try...
2024-03-13 13:44:48,177 container.py:103        INFO  Container 'e8bc11796e83af325171442d911f0ff2102804469a4410e62455f9d652038588' removed

@ubi8/openjdk-8 @ubi8/openjdk-11 @ubi8/openjdk-17 @ubi8/openjdk-21
Feature: Openshift S2I tests # features/jboss.container.s2i.core.api/s2i-core.feature:5

Feature: Miscellaneous general settings unit tests # features/jboss.container.user/general.feature:1

1 feature passed, 0 failed, 14 skipped
1 scenario passed, 0 failed, 91 skipped
2 steps passed, 0 failed, 264 skipped, 0 undefined
Took 0m10.766s
2024-03-13 13:44:48,178 cli.py:531        INFO  Finished!

…ule/jdk/tests/features

Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@jhuttana jhuttana requested a review from jmtd March 13, 2024 08:52
Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jmtd jmtd merged commit ce3472a into rh-openjdk:ubi8 Mar 13, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants