OPENJDK-2734: Stage 2 initial implementation #474
Conversation
| @@ -49,3 +58,31 @@ objects: | |||
| to: | |||
| kind: ImageStreamTag | |||
| name: ubi9-openjdk-${JDK_VERSION}-jlink:latest | |||
| - apiVersion: build.openshift.io/v1 | |||
| kind: BuildConfig | |||
There was a problem hiding this comment.
BuildConfig is OpenShift specific. It would be best to design this based on Builds for Red Hat OpenShift which is k8s specific which covers a broader range of deployments and would be more forward-looking:
https://access.redhat.com/documentation/en-us/builds_for_red_hat_openshift/1.0
There was a problem hiding this comment.
I think we need to move to Build instead of buildConfig, yes (also in #471). I won't block merging this to jlink-dev for that reason, though, it goes on the TODO list.
Signed-off-by: Jonathan Dowland <[email protected]>
quote "true" to avoid OpenShift trying to interpret it as a Boolean type. Signed-off-by: Jonathan Dowland <[email protected]>
|
@Josh-Matsuoka , thanks for raising this PR. This is great! I've just done a thorough test of this and an attempt at combining it with the other templates to run the whole thing through end-to-end. I've just pushed two commits to your branch/this PR to resolve some immediate syntax problems. I'm just putting together the next steps we need to do and I can cover that when we meet later. |
Initial implementation of build stage 2, addresses OPENJDK-2734
Leaving as draft for the moment, I'll do a second pass over it tomorrow. Wanted to get this out ahead of the meeting.