[OPENJDK-2722] UBI8: Suitably rename the test #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuttana
changed the title
|
Please include a link to the relevant JIRA issue in all PRs (I've edited it into this one). The referenced issue is for UBI9 but this issue is targetting UBI8. What's the motivation for renaming the file? Please include that in the commit message. |
jhuttana
changed the title
Actually I don't have JIRA tracker specific to this. The suitable one I found is OPENJDK-2722 so adding that to the title.
Sorry that was misleading.
Sure I will add that |
The rationale is, these are not openshift tests. Instead checks for some common label and image labels are correct. So its good to rename the test. Signed-off-by: Jayashree Huttanagoudar <[email protected]>
jhuttana
force-pushed
the
ubi8_rename_test
branch
from
716a3a7 to
dd4099e
Compare
jmtd
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please take a look?
https://issues.redhat.com/browse/OPENJDK-2722