[OPENJDK-2824] assemble: binary: Don't set times on directories (UBI8) #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test which ensures s2i binary-build works with a destination directory not owned by UID 185 (/var/tmp), which means the running process does not have permission to change its timestamps, simulating a random UID and the permissions on /deployments. Signed-off-by: Jonathan Dowland <[email protected]>
If the S2I build runs as a user other than 185 (such as s2i's default of 1001), attempting to set the timestamp of /deployments will fail, causing the build to fail. https://issues.redhat.com/browse/OPENJDK-2824 See also https://issues.redhat.com/browse/OPENJDK-2408 Signed-off-by: Jonathan Dowland <[email protected]>
|
Running tests locally... |
|
New test passes. Running the whole suite now |
jerboaa
approved these changes
Apr 15, 2024
|
whole suite passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the S2I build runs as a user other than 185 (such as s2i's default
of 1001), attempting to set the timestamp of /deployments will fail,
causing the build to fail.
https://issues.redhat.com/browse/OPENJDK-2824
See also
https://issues.redhat.com/browse/OPENJDK-2408
Backport of #470