Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-2899]Add hooks for stage-2 build #489

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

jhuttana
Copy link
Contributor

@jhuttana jhuttana commented Apr 29, 2024

JIRA: https://issues.redhat.com/browse/OPENJDK-2899
Could you please take a look?

I haven't created the webhook yet.

Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@jhuttana jhuttana requested a review from jmtd April 29, 2024 12:35
@jhuttana
Copy link
Contributor Author

I have made the suggested changes to generate random value for secret.
Also, verified that the value is getting substituted appropriately in the buildConfig after template is instantiated.

$ oc process --parameters=true jlink-app-template
NAME                    DESCRIPTION                                                GENERATOR           VALUE
JDK_VERSION             JDK version to produce a jmods image and imagestream for                       11
APP_URI                 Application to run the jlink workflow on                                       
REF                     Git Ref to run the jlink workflow on                                           
CONTEXT_DIR             Context Dir to use for the jlink workflow                                      
GITHUB_WEBHOOK_SECRET   A secret string used to configure the GitHub webhook       expression          [a-zA-Z0-9]{16}
$  oc get bc
NAME                     TYPE     FROM         LATEST
jlink-builder-jdk-17     Docker   Dockerfile   0
jlink-s2i-jdk-17         Source   Git@master   0
multistage-buildconfig   Docker   Dockerfile   1
$ oc get -o yaml bc/jlink-s2i-jdk-17
.
.
.
triggers:
.
.
.
  - github:
      secret: REuvkipBJ3aWOFEE
    type: GitHub
status:
  lastVersion: 0

Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@jmtd jmtd merged commit 1c9bc41 into rh-openjdk:jlink-dev Apr 30, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants